Login | Register
My pages Projects Community openCollabNet

Discussions > users > Re: [gef-users] backward compatibility and 0.10.4

gef
Discussion topic

Back to topic list

Re: [gef-users] backward compatibility and 0.10.4

Reply

Author Bob Tarling <bob dot tarling at ntlworld dot com>
Full name Bob Tarling <bob dot tarling at ntlworld dot com>
Date 2004-06-18 11:52:15 PDT
Message > One of the changes in org.tigris.gef.graph​.presentation.JGraph​ was
> changing the JScrollPane _scroll from protected to private. This means
> that I can scroll using the program as CmdScroll doesn't do anything and
> there are no methods to access _scroll.
It looks like I was slightly overzealous in my encapsulation here. This
should have been done slower with deprecation first.
My feeling was with JGraph was that it was unlikely to be extended and so a
move from protected to private should have no effect to the end user.
The process of stricter encapsulation will continue but I'll try to be more
giving in future.

However I do want to try and get the API under control. One of the
criticisms I've had is that the API is too open and it's not always obvious
what is meant to be accessible to the client coder and what to the GEF
developer.

> I believe it should be either:
> 1. make _scroll protected as before so we can access using a class that
> extends JGraph or
> 2. have a method getScrollPane() or something similar (I would prefer
> this) or
> 3. JGraph directly provide methods that map to required methods to do
> the scrolling.
My preference here would be for 3, hiding from the client coder as much of
GEF's implementation as possible and simply provide something like

void setHorizontalScroll(int x)
void setVerticalScroll(int y)
int getHorizontalScroll()
int getVerticalScroll()

I seem to be making a release about once a month at the moment. If you can
do without the fixes in 0.10.4 then stick to the previous release and take
0.10.5 next month.

Regards

Bob.

P.S. Feel free to report this issues directly into the bugs database at any
time. Makes it easier for me to keep track.



----- Original Message -----
From: "Ashish Shrestha" <ashish.shrestha@​sysdm.com>
To: <users at gef dot tigris dot org>
Sent: Friday, June 18, 2004 11:32 AM
Subject: [gef-users] backward compatibility and 0.10.4


> Hi,
>
> One of the changes in org.tigris.gef.graph​.presentation.JGraph​ was
> changing the JScrollPane _scroll from protected to private. This means
> that I can scroll using the program as CmdScroll doesn't do anything and
> there are no methods to access _scroll.
>
> Anyway, if you did implement CmdScroll, I don't know exactly how it
> would do the scrolling with out access to _scroll.
>
> I believe it should be either:
> 1. make _scroll protected as before so we can access using a class that
> extends JGraph or
> 2. have a method getScrollPane() or something similar (I would prefer
> this) or
> 3. JGraph directly provide methods that map to required methods to do
> the scrolling.
>
> Regards,
> Ashish
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: users-unsubscribe@ge​f.tigris.org
> For additional commands, e-mail: users-help at gef dot tigris dot org
>


--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: users-unsubscribe@ge​f.tigris.org
For additional commands, e-mail: users-help at gef dot tigris dot org

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

[gef-users] backward compatibility and 0.10.4 Ashish Shrestha <ashish dot shrestha at sysdm dot com> Ashish Shrestha <ashish dot shrestha at sysdm dot com> 2004-06-18 03:32:01 PDT
     Re: [gef-users] backward compatibility and 0.10.4 Bob Tarling <bob dot tarling at ntlworld dot com> Bob Tarling <bob dot tarling at ntlworld dot com> 2004-06-18 11:52:15 PDT
Messages per page: