Login | Register
My pages Projects Community openCollabNet

Discussions > dev > [gef-dev] ArgoUML issue 1048.

gef
Discussion topic

Hide all messages in topic

All messages in topic

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-10 00:29:15 PST
Message Done.

Bob Tarling wrote:
> Maybe its woth gathering a single issue for path strategy improvements then.
>
> I'll give 48 hours but if you're ready before then let me know.
>
> Cheers
>
> Bob.
>
>
> 2008/12/9 Dave Thompson <argouml at davet dot org>:
>> 48 hours?
>>
>> I also have a couple of other changes that I'd like to make to
>> PathItemPlacementStrategy.java and PathConv.java. This is to provide
>> setLocation() and getLocation().
>>
>> Regards,
>>
>> Dave
>>
>> Bob Tarling wrote:
>>> Go for it.
>>>
>>> But please do create the issue first so that I have some issue to
>>> reference in the release notes.
>>>
>>> How long do you need for this? I'd like to do a new milestone soon and
>>> I gather you'd like to have this available for Argo.
>>>
>>> Regards
>>>
>>> Bob.
>>>
>>>
>>> 2008/12/9 Dave Thompson <argouml at davet dot org>:
>>>> Bob Tarling wrote:
>>>>> I just opened the patch attached to your email and it contains the
>>>>> same text as your email, so I can't comment on that directly.
>>>> Here it is again, inline this time..
>>>>
>>>> Dave
>>>>
>>>>
>>>>
>>>>
>>>> Index: src/org/tigris/gef/p​resentation/FigEdge.​java
>>>> ====================​====================​====================​=======
>>>> --- src/org/tigris/gef/p​resentation/FigEdge.​java (revision 1184)
>>>> +++ src/org/tigris/gef/p​resentation/FigEdge.​java (working copy)
>>>> @@ -366,6 +366,27 @@
>>>>
>>>> return figs;
>>>> }
>>>> +
>>>> + /**
>>>> + * Gets the PathItemPlacementStrategy for the given fig.
>>>> + * The given fig must be one of the pathItem figs, otherwise null will be
>>>> + * returned.
>>>> + * @param fig The fig to look for.
>>>> + * @return The PathItemPlacementStrategy for fig.
>>>> + */
>>>> + public PathItemPlacementStrategy getPathItemPlacement​Strategy(Fig fig) {
>>>> + for (PathItem pi : _pathItems) {
>>>> + Fig f = getPathItemFig(pi);
>>>> + if (fig.equals(f)) {
>>>> + return pi.getPathItemPlacem​entStrategy();
>>>> + }
>>>> + }
>>>> + // Something bad has happened if we get here, it means the fig that
>>>> + // we were asked to look for was not on a PathItem.
>>>> + //System.out.println("Could not find PathItemPlacementStrategy for fig '"
>>>> + // + fig + "'.");
>>>> + return null;
>>>> + }
>>>>
>>>> /**
>>>> * Return the vector of path items on this FigEdge.
>>>>
>>>> --------------------​--------------------​--------------
>>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981861
>>>>
>>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>>
>>> --------------------​--------------------​--------------
>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981869
>>>
>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981898
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981899
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-09 14:46:54 PST
Message Maybe its woth gathering a single issue for path strategy improvements then.

I'll give 48 hours but if you're ready before then let me know.

Cheers

Bob.


2008/12/9 Dave Thompson <argouml at davet dot org>:
> 48 hours?
>
> I also have a couple of other changes that I'd like to make to
> PathItemPlacementStrategy.java and PathConv.java. This is to provide
> setLocation() and getLocation().
>
> Regards,
>
> Dave
>
> Bob Tarling wrote:
>> Go for it.
>>
>> But please do create the issue first so that I have some issue to
>> reference in the release notes.
>>
>> How long do you need for this? I'd like to do a new milestone soon and
>> I gather you'd like to have this available for Argo.
>>
>> Regards
>>
>> Bob.
>>
>>
>> 2008/12/9 Dave Thompson <argouml at davet dot org>:
>>> Bob Tarling wrote:
>>>> I just opened the patch attached to your email and it contains the
>>>> same text as your email, so I can't comment on that directly.
>>> Here it is again, inline this time..
>>>
>>> Dave
>>>
>>>
>>>
>>>
>>> Index: src/org/tigris/gef/p​resentation/FigEdge.​java
>>> ====================​====================​====================​=======
>>> --- src/org/tigris/gef/p​resentation/FigEdge.​java (revision 1184)
>>> +++ src/org/tigris/gef/p​resentation/FigEdge.​java (working copy)
>>> @@ -366,6 +366,27 @@
>>>
>>> return figs;
>>> }
>>> +
>>> + /**
>>> + * Gets the PathItemPlacementStrategy for the given fig.
>>> + * The given fig must be one of the pathItem figs, otherwise null will be
>>> + * returned.
>>> + * @param fig The fig to look for.
>>> + * @return The PathItemPlacementStrategy for fig.
>>> + */
>>> + public PathItemPlacementStrategy getPathItemPlacement​Strategy(Fig fig) {
>>> + for (PathItem pi : _pathItems) {
>>> + Fig f = getPathItemFig(pi);
>>> + if (fig.equals(f)) {
>>> + return pi.getPathItemPlacem​entStrategy();
>>> + }
>>> + }
>>> + // Something bad has happened if we get here, it means the fig that
>>> + // we were asked to look for was not on a PathItem.
>>> + //System.out.println("Could not find PathItemPlacementStrategy for fig '"
>>> + // + fig + "'.");
>>> + return null;
>>> + }
>>>
>>> /**
>>> * Return the vector of path items on this FigEdge.
>>>
>>> --------------------​--------------------​--------------
>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981861
>>>
>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>
>>
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981869
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981898
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-09 14:42:37 PST
Message 48 hours?

I also have a couple of other changes that I'd like to make to
PathItemPlacementStrategy.java and PathConv.java. This is to provide
setLocation() and getLocation().

Regards,

Dave

Bob Tarling wrote:
> Go for it.
>
> But please do create the issue first so that I have some issue to
> reference in the release notes.
>
> How long do you need for this? I'd like to do a new milestone soon and
> I gather you'd like to have this available for Argo.
>
> Regards
>
> Bob.
>
>
> 2008/12/9 Dave Thompson <argouml at davet dot org>:
>> Bob Tarling wrote:
>>> I just opened the patch attached to your email and it contains the
>>> same text as your email, so I can't comment on that directly.
>> Here it is again, inline this time..
>>
>> Dave
>>
>>
>>
>>
>> Index: src/org/tigris/gef/p​resentation/FigEdge.​java
>> ====================​====================​====================​=======
>> --- src/org/tigris/gef/p​resentation/FigEdge.​java (revision 1184)
>> +++ src/org/tigris/gef/p​resentation/FigEdge.​java (working copy)
>> @@ -366,6 +366,27 @@
>>
>> return figs;
>> }
>> +
>> + /**
>> + * Gets the PathItemPlacementStrategy for the given fig.
>> + * The given fig must be one of the pathItem figs, otherwise null will be
>> + * returned.
>> + * @param fig The fig to look for.
>> + * @return The PathItemPlacementStrategy for fig.
>> + */
>> + public PathItemPlacementStrategy getPathItemPlacement​Strategy(Fig fig) {
>> + for (PathItem pi : _pathItems) {
>> + Fig f = getPathItemFig(pi);
>> + if (fig.equals(f)) {
>> + return pi.getPathItemPlacem​entStrategy();
>> + }
>> + }
>> + // Something bad has happened if we get here, it means the fig that
>> + // we were asked to look for was not on a PathItem.
>> + //System.out.println("Could not find PathItemPlacementStrategy for fig '"
>> + // + fig + "'.");
>> + return null;
>> + }
>>
>> /**
>> * Return the vector of path items on this FigEdge.
>>
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981861
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981869
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-09 13:46:30 PST
Message Go for it.

But please do create the issue first so that I have some issue to
reference in the release notes.

How long do you need for this? I'd like to do a new milestone soon and
I gather you'd like to have this available for Argo.

Regards

Bob.


2008/12/9 Dave Thompson <argouml at davet dot org>:
> Bob Tarling wrote:
>> I just opened the patch attached to your email and it contains the
>> same text as your email, so I can't comment on that directly.
>
> Here it is again, inline this time..
>
> Dave
>
>
>
>
> Index: src/org/tigris/gef/p​resentation/FigEdge.​java
> ====================​====================​====================​=======
> --- src/org/tigris/gef/p​resentation/FigEdge.​java (revision 1184)
> +++ src/org/tigris/gef/p​resentation/FigEdge.​java (working copy)
> @@ -366,6 +366,27 @@
>
> return figs;
> }
> +
> + /**
> + * Gets the PathItemPlacementStrategy for the given fig.
> + * The given fig must be one of the pathItem figs, otherwise null will be
> + * returned.
> + * @param fig The fig to look for.
> + * @return The PathItemPlacementStrategy for fig.
> + */
> + public PathItemPlacementStrategy getPathItemPlacement​Strategy(Fig fig) {
> + for (PathItem pi : _pathItems) {
> + Fig f = getPathItemFig(pi);
> + if (fig.equals(f)) {
> + return pi.getPathItemPlacem​entStrategy();
> + }
> + }
> + // Something bad has happened if we get here, it means the fig that
> + // we were asked to look for was not on a PathItem.
> + //System.out.println("Could not find PathItemPlacementStrategy for fig '"
> + // + fig + "'.");
> + return null;
> + }
>
> /**
> * Return the vector of path items on this FigEdge.
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981861
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-09 13:36:04 PST
Message Bob Tarling wrote:
> I just opened the patch attached to your email and it contains the
> same text as your email, so I can't comment on that directly.

Here it is again, inline this time..

Dave




Index: src/org/tigris/gef/p​resentation/FigEdge.​java
====================​====================​====================​=======
--- src/org/tigris/gef/p​resentation/FigEdge.​java (revision 1184)
+++ src/org/tigris/gef/p​resentation/FigEdge.​java (working copy)
@@ -366,6 +366,27 @@

          return figs;
      }
+
+ /**
+ * Gets the PathItemPlacementStrategy for the given fig.
+ * The given fig must be one of the pathItem figs, otherwise null will be
+ * returned.
+ * @param fig The fig to look for.
+ * @return The PathItemPlacementStrategy for fig.
+ */
+ public PathItemPlacementStrategy getPathItemPlacement​Strategy(Fig fig) {
+ for (PathItem pi : _pathItems) {
+ Fig f = getPathItemFig(pi);
+ if (fig.equals(f)) {
+ return pi.getPathItemPlacem​entStrategy();
+ }
+ }
+ // Something bad has happened if we get here, it means the fig that
+ // we were asked to look for was not on a PathItem.
+ //System.out.println("Could not find PathItemPlacementStrategy for fig '"
+ // + fig + "'.");
+ return null;
+ }

      /**
       * Return the vector of path items on this FigEdge.

Re: [gef-dev] ArgoUML issue 1048.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-09 13:26:04 PST
Message I just opened the patch attached to your email and it contains the
same text as your email, so I can't comment on that directly.

Option B does sound good to me though

Please create an issue first, I'll need that for my release notes.
Describe what you plan to do there and fix it.

Attach the patch there first if you prefer

Is this likely to take place soon? I need to get a new GEF release for
the seq2 diagrams.

Regards

Bob.

2008/12/9 Dave Thompson <argouml at davet dot org>:
> Hi,
>
> Since what I'm about to talk about really is a GEF question, not an ArgoUML
> one, I'm sending it to the GEF list.
>
> While working on issue1048, I have come to the problem of accessing the
> PathItemPlacementStrategy for a given Fig (such as a label) on a FigEdge. I
> need to access the PathItemPlacementStrategy, so that I can modify it's fields.
>
> In the repository at the moment, once a pathItem has been created, I think
> the access I have at a later date is quite limited. Assuming all I've got is
> a reference to the FigEdge, all I can do is use
> FigEdge.getPathItemStrategies() to get a list of all of the pathitems used
> within that fig. Unfortunately, this does not help me to find out which
> PathItem is associated with the Fig I am interested in. I can iterate
> through the list, but all I can do is paint() or getPoint(), neither of these
> helps me pin down the fig.
>
> Possible options (there may be more!):
>
> A) One option is of course to add more to the PathItemPlacementStrategy
> interface, with a getFig() method for getting the anchored Fig. I could then
> use this method during my search, to try each pathitem until the getFig()
> pointed to the fig I was interested in.
>
> B) My preferred option would be to add a method to figEdge:
> getPathItemPlacement​Strategy(Fig fig). This method could be used to directly
> return the PathItemPlacementStrategy for a particular fig. I think that if
> we did this, we would probably no longer need the getPathItemStrategies() method.
>
> I've out B and it works, with a few other changes to ArgoUML. Attached is my
> patch.
>
> (Bob?) please advise on which way you would like me to proceed.
>
> Kind regards,
>
> Dave
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981842
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
> Hi,
>
> Since what I'm about to talk about really is a GEF question, not an ArgoUML
> one, I'm sending it to the GEF list.
>
> While working on issue1048, I have come to the problem of accessing the
> PathItemPlacementStrategy for a given Fig (such as a label) on a FigEdge. I
> need to access the PathItemPlacementStrategy, so that I can modify it's fields.
>
> In the repository at the moment, once a pathItem has been created, I think
> the access I have at a later date is quite limited. Assuming all I've got is
> a reference to the FigEdge, all I can do is use
> FigEdge.getPathItemStrategies() to get a list of all of the pathitems used
> within that fig. Unfortunately, this does not help me to find out which
> PathItem is associated with the Fig I am interested in. I can iterate
> through the list, but all I can do is paint() or getPoint(), neither of these
> helps me pin down the fig.
>
> Possible options (there may be more!):
>
> A) One option is of course to add more to the PathItemPlacementStrategy
> interface, with a getFig() method for getting the anchored Fig. I could then
> use this method during my search, to try each pathitem until the getFig()
> pointed to the fig I was interested in.
>
> B) My preferred option would be to add a method to figEdge:
> getPathItemPlacement​Strategy(Fig fig). This method could be used to directly
> return the PathItemPlacementStrategy for a particular fig. I think that if
> we did this, we would probably no longer need the getPathItemStrategies() method.
>
> I've out B and it works, with a few other changes to ArgoUML. Attached is my
> patch.
>
> (Bob?) please advise on which way you would like me to proceed.
>
> Kind regards,
>
> Dave
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=981842
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>

[gef-dev] ArgoUML issue 1048.

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-09 12:51:19 PST
Message Hi,

Since what I'm about to talk about really is a GEF question, not an ArgoUML
one, I'm sending it to the GEF list.

While working on issue1048, I have come to the problem of accessing the
PathItemPlacementStrategy for a given Fig (such as a label) on a FigEdge. I
need to access the PathItemPlacementStrategy, so that I can modify it's fields.

In the repository at the moment, once a pathItem has been created, I think
the access I have at a later date is quite limited. Assuming all I've got is
a reference to the FigEdge, all I can do is use
FigEdge.getPathItemStrategies() to get a list of all of the pathitems used
within that fig. Unfortunately, this does not help me to find out which
PathItem is associated with the Fig I am interested in. I can iterate
through the list, but all I can do is paint() or getPoint(), neither of these
helps me pin down the fig.

Possible options (there may be more!):

A) One option is of course to add more to the PathItemPlacementStrategy
interface, with a getFig() method for getting the anchored Fig. I could then
use this method during my search, to try each pathitem until the getFig()
pointed to the fig I was interested in.

B) My preferred option would be to add a method to figEdge:
getPathItemPlacement​Strategy(Fig fig). This method could be used to directly
return the PathItemPlacementStrategy for a particular fig. I think that if
we did this, we would probably no longer need the getPathItemStrategies() method.

I've out B and it works, with a few other changes to ArgoUML. Attached is my
patch.

(Bob?) please advise on which way you would like me to proceed.

Kind regards,

Dave
Messages per page: