Login | Register
My pages Projects Community openCollabNet

Discussions > dev > [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

gef
Discussion topic

Hide all messages in topic

All messages in topic

Re: [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author penyaskito
Full name Christian López Espínola
Date 2008-12-06 11:24:17 PST
Message On Fri, Dec 5, 2008 at 1:52 AM, Bob Tarling <bob dot tarling at gmail dot com> wrote:
> I finished reverting some changes in GEF and remade the milestone 2 -
> http://gef.tigris.or​g/files/documents/9/​44486/GEF-0.13M2-bin​.zip
>
> If anyone has any advice of how to progress GEF with generics and not
> break apps like ArgoUML then please help out.

I've just commited a test that, by using reflection for getting the
possible conflict methods, assures that this problem doesn't happen.
BTW, this is only a stub of how we can test those in a general way,
without adding new specific tests for specific methods, but this test
could (and must) be improved.

Improvements that come to my mind right now:
- We only test those methods that receive a Collection<?>. We need to
be sure that other methods, p.e. receiving Collection<?>,
someOtherType are tested too.
- We need to take care that this tests all the methods that receive
generics. The logic is very simple for now.

See http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=5948&d​sMessageId=980559
for the diff.

I'll recommend all of you to start executing all the tests before
commiting. It takes less than 2 seconds in my laptop, and we are
starting to have some util tests there.


> Regards
>
> Bob.
>
>
> 2008/12/4 Bob Tarling <bob dot tarling at gmail dot com>:
>> I'm having trouble resolving this in a short period of time
>>
>> I'll revert some of the generic changes to the API and we then need to
>> put more though into how to move forward.
>>
>> Bob
>>
>>
>> 2008/12/4 Christian López Espínola <penyaskito at gmail dot com>:
>>> On Thu, Dec 4, 2008 at 11:22 PM, Bob Tarling <bob dot tarling at gmail dot com> wrote:
>>>> Hmmm
>>>>
>>>> Leave it with me a few minutes. I'm experimenting with a work around.
>>>
>>> Oops... We failed on this. We need to fix in GEF, it should be
>>>
>>> public FigGroup (List<? extends Fig>)
>>>
>>> I'm worried about how many problems like this we have introduced.
>>>
>>>
>>>> I hadn't baselined M2 anyway so I can rebuild.
>>>>
>>>> Bob.
>>>>
>>>>
>>>> 2008/12/4 Dave Thompson <argouml at davet dot org>:
>>>>> Hi All,
>>>>>
>>>>> Does anyone else have the same problem? While trying to use a local working
>>>>> copy of GEF compiled to work with ArgoUML, I get the following errors:
>>>>>
>>>>> Description Resource Path Location Type
>>>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
>>>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
>>>>> The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
>>>>> FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
>>>>> 1278 Java Problem
>>>>>
>>>>> If I use the compiled GEF library, it works fine. It looks like
>>>>>
>>>>> public ArgoFigGroup(List​<ArgoFig> arg0) {
>>>>> super(arg0);
>>>>> }
>>>>>
>>>>> Doesn't like calling super(arg0) because the super constructor wants a
>>>>> List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
>>>>> to List<Fig> does not work (even though ArgoFig is a sub class of Fig).
>>>>>
>>>>> It seems that this problem was introduced in rev1157 by Bob while converting
>>>>> to use generics.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Dave
>>>>>
>>>>> --------------------​--------------------​--------------
>>>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979850
>>>>>
>>>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>>>
>>>>
>>>> --------------------​--------------------​--------------
>>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979857
>>>>
>>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>>
>>>
>>>
>>>
>>> --
>>> Cheers,
>>>
>>> Christian López Espínola <penyaskito>
>>>
>>> --------------------​--------------------​--------------
>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979864
>>>
>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979893
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>



--
Cheers,

Christian López Espínola <penyaskito>

Re: [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-04 16:52:50 PST
Message I finished reverting some changes in GEF and remade the milestone 2 -
http://gef.tigris.or​g/files/documents/9/​44486/GEF-0.13M2-bin​.zip

If anyone has any advice of how to progress GEF with generics and not
break apps like ArgoUML then please help out.

Regards

Bob.


2008/12/4 Bob Tarling <bob dot tarling at gmail dot com>:
> I'm having trouble resolving this in a short period of time
>
> I'll revert some of the generic changes to the API and we then need to
> put more though into how to move forward.
>
> Bob
>
>
> 2008/12/4 Christian López Espínola <penyaskito at gmail dot com>:
>> On Thu, Dec 4, 2008 at 11:22 PM, Bob Tarling <bob dot tarling at gmail dot com> wrote:
>>> Hmmm
>>>
>>> Leave it with me a few minutes. I'm experimenting with a work around.
>>
>> Oops... We failed on this. We need to fix in GEF, it should be
>>
>> public FigGroup (List<? extends Fig>)
>>
>> I'm worried about how many problems like this we have introduced.
>>
>>
>>> I hadn't baselined M2 anyway so I can rebuild.
>>>
>>> Bob.
>>>
>>>
>>> 2008/12/4 Dave Thompson <argouml at davet dot org>:
>>>> Hi All,
>>>>
>>>> Does anyone else have the same problem? While trying to use a local working
>>>> copy of GEF compiled to work with ArgoUML, I get the following errors:
>>>>
>>>> Description Resource Path Location Type
>>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
>>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
>>>> The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
>>>> FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
>>>> 1278 Java Problem
>>>>
>>>> If I use the compiled GEF library, it works fine. It looks like
>>>>
>>>> public ArgoFigGroup(List​<ArgoFig> arg0) {
>>>> super(arg0);
>>>> }
>>>>
>>>> Doesn't like calling super(arg0) because the super constructor wants a
>>>> List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
>>>> to List<Fig> does not work (even though ArgoFig is a sub class of Fig).
>>>>
>>>> It seems that this problem was introduced in rev1157 by Bob while converting
>>>> to use generics.
>>>>
>>>> Regards,
>>>>
>>>> Dave
>>>>
>>>> --------------------​--------------------​--------------
>>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979850
>>>>
>>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>>
>>>
>>> --------------------​--------------------​--------------
>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979857
>>>
>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>
>>
>>
>>
>> --
>> Cheers,
>>
>> Christian López Espínola <penyaskito>
>>
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979864
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>

Re: [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-04 15:53:14 PST
Message I'm having trouble resolving this in a short period of time

I'll revert some of the generic changes to the API and we then need to
put more though into how to move forward.

Bob


2008/12/4 Christian López Espínola <penyaskito at gmail dot com>:
> On Thu, Dec 4, 2008 at 11:22 PM, Bob Tarling <bob dot tarling at gmail dot com> wrote:
>> Hmmm
>>
>> Leave it with me a few minutes. I'm experimenting with a work around.
>
> Oops... We failed on this. We need to fix in GEF, it should be
>
> public FigGroup (List<? extends Fig>)
>
> I'm worried about how many problems like this we have introduced.
>
>
>> I hadn't baselined M2 anyway so I can rebuild.
>>
>> Bob.
>>
>>
>> 2008/12/4 Dave Thompson <argouml at davet dot org>:
>>> Hi All,
>>>
>>> Does anyone else have the same problem? While trying to use a local working
>>> copy of GEF compiled to work with ArgoUML, I get the following errors:
>>>
>>> Description Resource Path Location Type
>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
>>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>>> argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
>>> The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
>>> FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
>>> 1278 Java Problem
>>>
>>> If I use the compiled GEF library, it works fine. It looks like
>>>
>>> public ArgoFigGroup(List​<ArgoFig> arg0) {
>>> super(arg0);
>>> }
>>>
>>> Doesn't like calling super(arg0) because the super constructor wants a
>>> List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
>>> to List<Fig> does not work (even though ArgoFig is a sub class of Fig).
>>>
>>> It seems that this problem was introduced in rev1157 by Bob while converting
>>> to use generics.
>>>
>>> Regards,
>>>
>>> Dave
>>>
>>> --------------------​--------------------​--------------
>>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979850
>>>
>>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>>
>>
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979857
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>
>
>
>
> --
> Cheers,
>
> Christian López Espínola <penyaskito>
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979864
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].

Re: [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author penyaskito
Full name Christian López Espínola
Date 2008-12-04 15:03:45 PST
Message On Thu, Dec 4, 2008 at 11:22 PM, Bob Tarling <bob dot tarling at gmail dot com> wrote:
> Hmmm
>
> Leave it with me a few minutes. I'm experimenting with a work around.

Oops... We failed on this. We need to fix in GEF, it should be

public FigGroup (List<? extends Fig>)

I'm worried about how many problems like this we have introduced.


> I hadn't baselined M2 anyway so I can rebuild.
>
> Bob.
>
>
> 2008/12/4 Dave Thompson <argouml at davet dot org>:
>> Hi All,
>>
>> Does anyone else have the same problem? While trying to use a local working
>> copy of GEF compiled to work with ArgoUML, I get the following errors:
>>
>> Description Resource Path Location Type
>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>> argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
>> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
>> argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
>> The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
>> FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
>> 1278 Java Problem
>>
>> If I use the compiled GEF library, it works fine. It looks like
>>
>> public ArgoFigGroup(List​<ArgoFig> arg0) {
>> super(arg0);
>> }
>>
>> Doesn't like calling super(arg0) because the super constructor wants a
>> List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
>> to List<Fig> does not work (even though ArgoFig is a sub class of Fig).
>>
>> It seems that this problem was introduced in rev1157 by Bob while converting
>> to use generics.
>>
>> Regards,
>>
>> Dave
>>
>> --------------------​--------------------​--------------
>> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979850
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>>
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979857
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>



--
Cheers,

Christian López Espínola <penyaskito>

Re: [gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-12-04 14:22:30 PST
Message Hmmm

Leave it with me a few minutes. I'm experimenting with a work around.

I hadn't baselined M2 anyway so I can rebuild.

Bob.


2008/12/4 Dave Thompson <argouml at davet dot org>:
> Hi All,
>
> Does anyone else have the same problem? While trying to use a local working
> copy of GEF compiled to work with ArgoUML, I get the following errors:
>
> Description Resource Path Location Type
> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
> argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
> The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
> argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
> The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
> FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
> 1278 Java Problem
>
> If I use the compiled GEF library, it works fine. It looks like
>
> public ArgoFigGroup(List​<ArgoFig> arg0) {
> super(arg0);
> }
>
> Doesn't like calling super(arg0) because the super constructor wants a
> List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
> to List<Fig> does not work (even though ArgoFig is a sub class of Fig).
>
> It seems that this problem was introduced in rev1157 by Bob while converting
> to use generics.
>
> Regards,
>
> Dave
>
> --------------------​--------------------​--------------
> http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=429&ds​MessageId=979850
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@gef​.tigris.org].
>

[gef-dev] Current GEF SVN does not compile with current ArgoUML svn.

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-04 13:58:25 PST
Message Hi All,

Does anyone else have the same problem? While trying to use a local working
copy of GEF compiled to work with ArgoUML, I get the following errors:

Description Resource Path Location Type
The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
argouml-app/src/org/​argouml/uml/diagram/​ui line 74 Java Problem
The constructor FigGroup(List<ArgoFig>) is undefined ArgoFigGroup.java
argouml-app/src/org/​argouml/uml/diagram/​ui line 85 Java Problem
The constructor ArrayList<Compart​mentFigText>(List​<Fig>) is undefined
FigUseCase.java argouml-app/src/org/​argouml/uml/diagram/​use_case/ui line
1278 Java Problem

If I use the compiled GEF library, it works fine. It looks like

     public ArgoFigGroup(List​<ArgoFig> arg0) {
         super(arg0);
     }

Doesn't like calling super(arg0) because the super constructor wants a
List<Fig> not a List<ArgoFig>. I don't know how to resolve this, as a cast
to List<Fig> does not work (even though ArgoFig is a sub class of Fig).

It seems that this problem was introduced in rev1157 by Bob while converting
to use generics.

Regards,

Dave
Messages per page: