Login | Register
My pages Projects Community openCollabNet

Discussions > dev > [gef-dev] Re: svn commit: r1186 - trunk/src/org/tigris/gef/base/SelectionManager.java

gef
Discussion topic

Back to topic list

[gef-dev] Re: svn commit: r1186 - trunk/src/org/tigris/gef/base/SelectionManager.java

Reply

Author dthompson
Full name Dave Thompson
Date 2008-12-09 13:22:29 PST
Message Hi Bob,

Sorry, the explanatory email exchange was not on the dev list, and I
probably should have made my revert message clearer. Full details below.

Regards, Dave

Bob Tarling wrote:
> I'm just curious. What was the problem with this?
>
> Bob.
>
Dave Thompson wrote:
 > Oh crap. You are right. I've reverted my change just in case. I don't
 > know a way of specifying the iteration range using the 'cleaner' for
 > loop nomenclature, so best stick to the old one for now.
 >
 > Thanks for noticing!
 >
 > Dave
 >
 > Christian López Espínola wrote:
 >> Hi Dave!
 >>
 >> On Tue, Dec 9, 2008 at 9:07 PM, Dave Thompson <argouml at davet dot org> wrote:
 >>> Author: dthompson
 >>> Date: 2008-12-09 12:07:58-0800
 >>> New Revision: 1185
 >>>
 >>> Modified:
 >>> trunk/src/org/tigris​/gef/base/SelectionM​anager.java
 >>>
 >>> Log:
 >>> Swapped over to generics inside one method, to simplify the code.
 >>>
 >>> Modified: trunk/src/org/tigris​/gef/base/SelectionM​anager.java
 >>> Url:
 >>>
http://gef.tigris.or​g/source/browse/gef/​trunk/src/org/tigris​/gef/base/SelectionM​anager.java?view=dif​f&pathrev=1185​&r1=1184&r2=11​85

 >>>
 >>>
====================​====================​====================​==================

 >>>
 >>> --- trunk/src/org/tigris​/gef/base/SelectionM​anager.java (original)
 >>> +++ trunk/src/org/tigris​/gef/base/SelectionM​anager.java 2008-12-09
 >>> 12:07:58-0800
 >>> @@ -772,11 +772,9 @@
 >>> }
 >>>
 >>> if (layer != null) {
 >>> - List editors = layer.getEditors();
 >>> - int editorCount = editors.size();
 >>> + List<Editor> editors = layer.getEditors();
 >>> Rectangle dirtyRegionScaled = new Rectangle();
 >>> - for (int editorIndex = 0; editorIndex < editorCount;
 >>> ++editorIndex) {
 >>> - Editor editor = (Editor) editors.get(editorIndex);
 >>> + for (Editor editor : editors) {
 >>
 >> Have you seen that it was ++editorIndex? We were not using the first
 >> editor in the list.
 >> Your works different, so I'm not sure if it was a bug, or we are
 >> introducing a bug.
 >>
 >>
 >>> double editorScale = editor.getScale();
 >>> dirtyRegionScaled.x = (int) Math.floor(dirtyRegion.x
 >>> * editorScale);
 >>>
 >>> --------------------​--------------------​--------------
 >>>
http://gef.tigris.or​g/ds/viewMessage.do?​dsForumId=5948&d​sMessageId=981833
 >>>
 >>>
 >>> To unsubscribe from this discussion, e-mail:
 >>> [commits-unsubscribe​@gef.tigris.org].
 >>>
 >>
 >>
 >>
 >

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

[gef-dev] Re: svn commit: r1186 - trunk/src/org/tigris/gef/base/SelectionManager.java dthompson Dave Thompson 2008-12-09 13:22:29 PST
Messages per page: