Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 320] New - FigEdge children handled inconsistently for drawing

gef
Discussion topic

Hide all messages in topic

All messages in topic

[Issue 320] FigEdge.intersects broken - causes redraw failures

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-11-23 07:30:22 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320



User bobtarling changed the following:

                What |Old value |New value
====================​====================​====================​====================​
        Target milestone|--- |0.13
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from bobtarling at tigris dot org Sun Nov 23 07:30:22 -0800 2008 -------
Set milestone

[Issue 320] FigEdge.intersects broken - causes redraw failures

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-11-19 17:32:16 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320



User bobtarling changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from bobtarling at tigris dot org Wed Nov 19 17:32:16 -0800 2008 -------
Fix commited. This reolves the problem in GEF Demo so I assume it will help
ArgoUML.

[Issue 320] FigEdge.intersects broken - causes redraw failures

Reply

Author tfmorris
Full name Tom Morris
Date 2008-11-17 07:48:53 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320






------- Additional comments from tfmorris at tigris dot org Mon Nov 17 07:48:52 -0800 2008 -------
There are screenshots demonstrating problem attached to the ArgoUML issue
http://argouml.tigri​s.org/issues/show_bu​g.cgi?id=5446

[Issue 320] FigEdge.intersects broken - causes redraw failures

Reply

Author dthompson
Full name Dave Thompson
Date 2008-11-16 10:50:00 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320



User dthompson changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                      CC|'' |'dthompson'
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from dthompson at tigris dot org Sun Nov 16 10:50:00 -0800 2008 -------
Adding me to CC list.

[Issue 320] FigEdge.intersects broken - causes redraw failures

Reply

Author tfmorris
Full name Tom Morris
Date 2008-11-16 08:27:13 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320



User tfmorris changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                Priority|P3 |P2
--------------------​--------------------​--------------------​--------------------​
                 Summary|FigEdge children handled i|FigEdge.intersects broken
                        |nconsistently for drawing |- causes redraw failures
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from tfmorris at tigris dot org Sun Nov 16 08:27:12 -0800 2008 -------
Increase priority

[Issue 320] FigEdge children handled inconsistently for drawing

Reply

Author bobtarling
Full name Bob Tarling
Date 2008-10-26 17:31:09 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320






------- Additional comments from bobtarling at tigris dot org Sun Oct 26 17:31:08 -0700 2008 -------
Agreed. I'll fix this for next release.

[Issue 320] New - FigEdge children handled inconsistently for drawing

Reply

Author tfmorris
Full name Tom Morris
Date 2008-10-14 14:28:25 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320
                 Issue #|320
                 Summary|FigEdge children handled inconsistently for drawing
               Component|gef
                 Version|current
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|issues@gef
             Reported by|tfmorris






------- Additional comments from tfmorris at tigris dot org Tue Oct 14 14:28:25 -0700 2008 -------
See ArgoUML issue 5460. The following code from FigEdge.intersects()

        for(int i = 0; i < size; i++) {
            Fig f = ((PathItem)_pathItem​s.elementAt(i)).getF​ig();
            //only pathitems represented in a layer (i.e. being displayed) are
of interest
            if(f.getLayer() != null && f.intersects(r)) {
                //System.out.println​("Intersects");
                return true;
            }
        }

will fail to draw child Figs which don't have their layer set, but there must be
other places in the code which don't enforce this behavior, because they do
often get drawn.

The handling should be consistent. Since the drawing code is driven by the
active layer and sub Figs should all be in the same layer as the parent fig, it
seems unnecessary (and needlessly expensive) to be checking for a null layer.
Messages per page: