Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 317] New - Move the broom function from shift-click to alt-click

gef
Discussion topic

Hide all messages in topic

All messages in topic

[gef-issues] [Issue 317] Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2009-08-13 23:11:42 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317



User mvw changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|STARTED |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from mvw at tigris dot org Thu Aug 13 23:11:41 -0700 2009 -------
Committed revision 1257 with the solution:

1. Left button: Shift-Click shall not invoke the broom; it toggles selection.
2. Left button: Alt-Drag shall invoke the normal broom.
3. Left button: Alt-Shift-Drag shall invoke the small broom.
4. Left button: Control-click toggles selection.
5. Middle-button: Dragging the canvas. Press shift to speed up.

[gef-issues] [Issue 317] Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2009-08-13 00:50:12 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317



User mvw changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |STARTED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from mvw at tigris dot org Thu Aug 13 00:50:12 -0700 2009 -------
The broom activation code is in the ModeSelect class.

I have some working code - needs a bit more testing.

[gef-issues] [Issue 317] Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2009-08-13 00:48:56 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317



User mvw changed the following:

                What |Old value |New value
====================​====================​====================​====================​
             Assigned to|bobtarling |mvw
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from mvw at tigris dot org Thu Aug 13 00:48:56 -0700 2009 -------
The canvas dragging is implemented by ModeDragScroll.

The comments in the code state that the dragging should happen when the middle
mouse button is used. This is button 2 in the implementation.

Also, there is some buggy old code based on Java versions before 1.4 to detect
which button is pressed with which modifiers. We can replace that now by the
Java 1.4 statements.

[Issue 317] Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2008-07-25 14:29:12 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317






------- Additional comments from mvw at tigris dot org Fri Jul 25 14:29:12 -0700 2008 -------
My tests revealed that there is another function under the Alt-Click: Drag the
canvas.
And the above mentioned change causes the broom to work with Ctrl-Alt click and
Ctrl-Alt-Shift click - to be investigated.

Maybe we should accept this - the broom can also be activated by a tool on the
toolbar.

[Issue 317] Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2008-07-21 04:50:50 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317






------- Additional comments from mvw at tigris dot org Mon Jul 21 04:50:50 -0700 2008 -------
I presume the work on this issue shall start with ModeSelect.mousePressed(), by
moving the function call
    gotoBroomMode(me)
up a few lines to below:
    if (me.isAltDown()) {
      ....


In this change acceptable to all GEF users?
Or do we make it configurable?

[Issue 317] New - Move the broom function from shift-click to alt-click

Reply

Author mvw
Full name Michiel van der Wulp
Date 2008-07-21 04:48:17 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=317
                 Issue #|317
                 Summary|Move the broom function from shift-click to alt-click
               Component|gef
                 Version|current
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|bobtarling
             Reported by|mvw






------- Additional comments from mvw at tigris dot org Mon Jul 21 04:48:16 -0700 2008 -------
Move the broom function from shift-click to alt-click.

See http://argouml.tigri​s.org/issues/show_bu​g.cgi?id=2190 for the rationale.

In short:
1. Shift-Click shall not invoke the broom.
2. Alt-Drag shall invoke the normal broom.
3. Alt-Shift-Drag shall invoke the small broom.
Messages per page: