Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [gef-issues] [Issue 354] New - ModeSelect selection bug when Zoomed.

gef
Discussion topic

Hide all messages in topic

All messages in topic

[gef-issues] [Issue 354] ModeSelect selection bug when Zoomed.

Reply

Author bobtarling
Full name Bob Tarling
Date 2010-12-04 05:53:17 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=354



User bobtarling changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from bobtarling at tigris dot org Sat Dec 4 05:53:17 -0800 2010 -------
Forgot to flag as fixed

[gef-issues] [Issue 354] ModeSelect selection bug when Zoomed.

Reply

Author bobtarling
Full name Bob Tarling
Date 2010-12-04 05:40:12 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=354






------- Additional comments from bobtarling at tigris dot org Sat Dec 4 05:40:12 -0800 2010 -------
Thanks Roland

Fixed in subversion - a release will take place soon

[gef-issues] [Issue 354] ModeSelect selection bug when Zoomed.

Reply

Author rquast
Full name Roland Quast
Date 2010-12-02 04:04:20 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=354






------- Additional comments from rquast at tigris dot org Thu Dec 2 04:04:20 -0800 2010 -------
Hi Bob,

Here is the patch for what I'm talking about. I am pretty sure it is a simple
fix, but probably a good idea to check.


--- ModeSelect.java.1258 2010-12-02 21:59:29.311858424 +1000
+++ ModeSelect.java.fixed 2010-12-02 22:00:58.495185255 +1000
@@ -254,7 +254,6 @@
                 LOG.debug("MouseReleased but rejected as meta key down");
             return;
         }
- editor.translateMouseEvent(me);

         int x = me.getX();
         int y = me.getY();
@@ -359,4 +358,4 @@
         // true
         return (me.isControlDown() && !me.isPopupTrigger()) || me.isMetaDown();
     }
-} /* end class ModeSelect */
\ No newline at end of file
+} /* end class ModeSelect */

[gef-issues] [Issue 354] ModeSelect selection bug when Zoomed.

Reply

Author bobtarling
Full name Bob Tarling
Date 2010-12-02 00:54:13 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=354






------- Additional comments from bobtarling at tigris dot org Thu Dec 2 00:54:13 -0800 2010 -------
Looks like you have already solved this. Do you have a patch you can attach
with the change?

Regards

Bob

[gef-issues] [Issue 354] New - ModeSelect selection bug when Zoomed.

Reply

Author rquast
Full name Roland Quast
Date 2010-12-01 22:17:37 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=354
                 Issue #|354
                 Summary|ModeSelect selection bug when Zoomed.
               Component|gef
                 Version|current
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P1
            Subcomponent|core
             Assigned to|bobtarling
             Reported by|rquast






------- Additional comments from rquast at tigris dot org Wed Dec 1 22:17:36 -0800 2010 -------
After zooming in on the editor and creating a fig in the editor, such as a
rectangle - once the fig is created, click to the right of it just slightly and
you will notice it is still selected. Worse still, once you start try editing
anything on the page when it is zoomed in, editing becomes impossible because it
is "magically" selecting figs from above where you click.

After much hunting around, I found out that ModeSelect's mouseReleased method
was translating the MouseEvent coordinates after the Editor's mouseReleased
event had already done this. The fix appears to be simple (may require further
testing), but I managed to get everything working properly after removing the
line in the mouseReleased method - editor.translateMouseEvent(me);

Anyone who as ever used GEF while zoomed in will surely have seen this problem.
Messages per page: