Login | Register
My pages Projects Community openCollabNet

gef
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author tfmorris
Full name Tom Morris
Date 2008-10-14 14:28:25 PDT
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=320
                 Issue #|320
                 Summary|FigEdge children handled inconsistently for drawing
               Component|gef
                 Version|current
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|issues@gef
             Reported by|tfmorris






------- Additional comments from tfmorris at tigris dot org Tue Oct 14 14:28:25 -0700 2008 -------
See ArgoUML issue 5460. The following code from FigEdge.intersects()

        for(int i = 0; i < size; i++) {
            Fig f = ((PathItem)_pathItem​s.elementAt(i)).getF​ig();
            //only pathitems represented in a layer (i.e. being displayed) are
of interest
            if(f.getLayer() != null && f.intersects(r)) {
                //System.out.println​("Intersects");
                return true;
            }
        }

will fail to draw child Figs which don't have their layer set, but there must be
other places in the code which don't enforce this behavior, because they do
often get drawn.

The handling should be consistent. Since the drawing code is driven by the
active layer and sub Figs should all be in the same layer as the parent fig, it
seems unnecessary (and needlessly expensive) to be checking for a null layer.