Login | Register
My pages Projects Community openCollabNet

gef
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author bobtarling
Full name Bob Tarling
Date 2010-11-28 01:52:21 PST
Message http://gef.tigris.or​g/issues/show_bug.cg​i?id=353
                 Issue #|353
                 Summary|SelectionMan​aged.deselectAll should do nothing if none
                        | selected
               Component|gef
                 Version|current
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|issues@gef
             Reported by|bobtarling






------- Additional comments from bobtarling at tigris dot org Sun Nov 28 01:52:21 -0800 2010 -------
ArgoUML is producing the following stacktrace

org.tigris.gef.base.​SelectionManager.des​electAll(SelectionMa​nager.java:227)
  [argouml] at
org.tigris.gef.graph​.presentation.JGraph​.setDiagram(JGraph.j​ava:304)
  [argouml] at
org.argouml.uml.diag​ram.ui.TabDiagram.se​tTarget(TabDiagram.j​ava:208)
  [argouml] at
org.argouml.uml.diag​ram.ui.TabDiagram$1​.run(TabDiagram.java​:406)
  [argouml] at
java.awt.event.Invoc​ationEvent.dispatch(​InvocationEvent.java​:209)
  [argouml] at java.awt.EventQueue.​dispatchEvent(EventQ​ueue.java:597)

This is happening because the work done in SelectionManager to remove all
selections is resulting in an event being fired to indicate a change to the
model. However if there are no selections then no model change has really
happened.

The quick solution here is for deslectAll to return immediately if it has
nothing to do.